KT-78051 Fix VerifyError with value class default argument in inline function #5644
+92
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladd-g
force-pushed
the
KT-78051
branch
2 times, most recently
from
746ec9d to
8d46097
Compare
…ction When an inline function has a value class parameter with a default value and the underlying type is nullable, the $default stub's parameter stays boxed while the implementation's parameter is unboxed. IrInlineDefaultCodegen copies bytecode verbatim, causing VerifyError due to the type mismatch. The fix checks for boxed inline class types in the stub's parameters and clears the DEFAULT_STUB_CALL_TO_IMPLEMENTATION origin, forcing IrInlineCodegen which handles type coercion correctly. ^KT-78051 fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes KT-78051
When an inline function has a value class parameter with a default value
and the underlying type is nullable, the
$defaultstub's parameter staysboxed while the implementation's parameter is unboxed.
IrInlineDefaultCodegencopies bytecode verbatim, causing
VerifyErrordue to the type mismatch.The fix checks for boxed inline class types in the stub's parameters
and clears the
DEFAULT_STUB_CALL_TO_IMPLEMENTATIONorigin, forcingIrInlineCodegenwhich handles type coercion correctly.